cvs commit: src/lib/libpthread/thread thr_attr_get_np.c thr_cancel.c thr_getschedparam.c thr_join.c thr_mutex_prioceiling.c thr_sigaction.c thr_sigmask.c thr_sigpending.c thr_sigsuspend.c

[David Xu]

----- Original Message ----- 
From: "David Schultz" <das at FreeBSD.ORG>
To: "David Xu" <davidxu at FreeBSD.ORG>
Cc: <src-committers at FreeBSD.ORG>; <cvs-src at FreeBSD.ORG>; <cvs-all at FreeBSD.ORG>
Sent: Monday, July 07, 2003 2:03 PM
Subject: Re: cvs commit: src/lib/libpthread/thread thr_attr_get_np.c thr_cancel.c thr_getschedparam.c thr_join.c thr_mutex_prioceiling.c thr_sigaction.c thr_sigmask.c thr_sigpending.c thr_sigsuspend.c


> On Sun, Jul 06, 2003, David Xu wrote:
> > davidxu     2003/07/06 21:28:23 PDT
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     lib/libpthread/thread thr_attr_get_np.c thr_cancel.c 
> >                           thr_getschedparam.c thr_join.c 
> >                           thr_mutex_prioceiling.c thr_sigaction.c 
> >                           thr_sigmask.c thr_sigpending.c 
> >                           thr_sigsuspend.c 
> >   Log:
> >   Avoid accessing user provided parameters in critical region.
> 
> Cool.  What happens if a page fault is taken in a critical region?
> Does this merely make the KSE unusable by other threads until the
> page is faulted in, or does it deadlock the UTS?  (If the latter
> is true, you'd need to wire a stack page or two to ensure
> correctness, or do soemthing differently.)
>

The change is nothing to do with page fault, also page fault
shouldn't cause deadlock. It is true the kse can not be used
by other threads if page fault occurs while in critical region.
For normal page fault not in critical region, kernel KSE codes
still does not call thread_user_enter(), but I want to insert
such call in trap.c, so when a page fault occurs, and thread
is blocked in paging, other threads still can run in userland,
if a user thread is in kernel mode, it is not affected.

David Xu