cvs commit: src/sys/alpha/alpha vm_machdep.c src/sys/amd64/amd64 vm_machdep.c src/sys/i386/i386 vm_machdep.c src/sys/ia64/ia64 vm_machdep.c src/sys/powerpc/powerpc vm_machdep.c

Sam Leffler sam at errno.com
Sat Dec 27 18:03:38 PST 2003


On Saturday 27 December 2003 05:56 pm, Mike Silbersack wrote:
> On Sat, 27 Dec 2003, Sam Leffler wrote:
> > >   Move the declaration of sfbufspeak and sfbufsused to mbuf.h,
> > >   and use imax instead of max, as sfbufspeak and sfbufsused
> > >   are signed.
> >
> > These have nothing to do with mbufs; why move the decls to mbuf.h?
> >
> > 	Sam
>
> Because I can't think of anywhere else sendfile related values would fit.
> So far our only use of sfbufs in the system is to attach them to mbufs and
> send them out via sockets.  FWIW, I'm about to overload mbstat with some
> sendfile statistics as well, because I can't think of another place that
> they would fit well.  I'm open to ideas, as long as they don't involve
> creating yet another header file.

Looks like there's an sf_buf.h.  If that's not to your liking perhaps systm.h 
or kernel.h.  Please don't pollute mbuf.h.

	Sam



More information about the cvs-src mailing list