cvs commit: src/sys/vm vm_page.h

[Poul-Henning Kamp]

In message <20030825190349.GC18841 at ns1.xcllnt.net>, Marcel Moolenaar writes:
>On Mon, Aug 25, 2003 at 01:38:36PM -0400, John Baldwin wrote:
>> 
>> On 23-Aug-2003 Marcel Moolenaar wrote:
>> > marcel      2003/08/22 23:24:00 PDT
>> > 
>> >   FreeBSD src repository
>> > 
>> >   Modified files:
>> >     sys/vm               vm_page.h 
>> >   Log:
>> >   Add support for 16K and 32K page sizes. The valid and dirty maps
>> >   in struct vm_page are defined as u_int for 16K pages and u_long
>> >   for 32K pages, with the implied assumption that long will at least
>> >   be 64 bits wide on platforms where we support 32K pages.
>> 
>> Why not use 'uint32_t' and 'uint64_t' to remove the assumption?
>
>I thought about that but decided not to do it because it would
>introduce a style variation that I considered worse than having
>the implied assumption.

Mark the assumption with a CTASSERT ?

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.