cvs commit: src/sys/dev/sym sym_fw.h

Johan Karlsson johan at FreeBSD.org
Tue Aug 5 05:28:23 PDT 2003


On Tue, Aug 05, 2003 at 00:22 (-0700) +0000, Diomidis Spinellis wrote:
> dds         2003/08/05 00:22:12 PDT
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/dev/sym          sym_fw.h 
>   Log:
>   Remove extraneous semicolons.  They are already provided by
>   the macro definition, and cause the generation of syntactically
>   incorrect code that gcc happens to accept.

This is backwards.

>From style(9):
						      Any final statement-ter-
     minating semicolon should be supplied by the macro invocation rather than
     the macro, to make parsing easier for pretty-printers and editors.

Please consider reverting this and change the macros in the file to not
supply the terminating semicolon.

/Johan K

>   
>   Reviewed by:    schweikh (mentor)
>   MFC after:      4 weeks
>   
>   Revision  Changes    Path
>   1.4       +4 -4      src/sys/dev/sym/sym_fw.h

-- 
Johan Karlsson		mailto:johan at FreeBSD.org


More information about the cvs-src mailing list