cvs commit: src/usr.sbin/pkg_install/lib match.c

[Joe Marcus Clarke]

On Sun, 3 Aug 2003, Bosko Milekic wrote:

>
> On Sun, Aug 03, 2003 at 08:02:36PM -0700, Bosko Milekic wrote:
> > bmilekic    2003/08/03 20:02:36 PDT
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     usr.sbin/pkg_install/lib match.c
> >   Log:
> >   Backout 1.14, it seems to be causing problems with libxml build
> >   and I don't have time to investigate this code in much detail right
> >   now.
>
> 	It's actually not the libxml build, but one that depends on both
> 	libxml and libxml2.

Actually, it affects a bunch of similar builds.  Any port with has another
port with a similar name (e.g. gnome vs. gnome2 ports, any portname with a
portname-devel, etc.) will run into this problem.  What happens is that
the port to be checked passes its origin to the matchbyorigin() function,
then that origin's strlen is passed to strncmp.  Therefore, it only checks
at most the number of characters in the original origin (missing the 2,
-devel, -snap, etc.).

Thanks for backing this out, Bosko.

Joe

>
> >   Revision  Changes    Path
> >   1.15      +1 -1      src/usr.sbin/pkg_install/lib/match.c
> >
>
> --
> Bosko Milekic  *  bmilekic at technokratis.com  *  bmilekic at FreeBSD.org
> TECHNOkRATIS Consulting Services  *  http://www.technokratis.com/
> _______________________________________________
> cvs-src at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/cvs-src
> To unsubscribe, send any mail to "cvs-src-unsubscribe at freebsd.org"
>
>

PGP Key : http://www.marcuscom.com/pgp.asc