cvs commit: src/sys/dev/fxp if_fxp.c if_fxpvar.h

Andrew Gallatin gallatin at cs.duke.edu
Tue Apr 29 13:09:07 PDT 2003


M. Warner Losh writes:
 > 
 > Comments?

Mostly OK by me, except for the // style comments.

Also, I'm not sure that checking for mutex_owned in the ioctl function
is right.  Picture ifconfig'ing an interface down (or starting
tcpdump) while you're undergoing a DOS attach.  Can you check for
suspened instead?

I'd still like to wrangle a generic, safe way of detaching interfaces
out of John though ;)

Drew


More information about the cvs-src mailing list