cvs commit: src/sys/pci if_dc.c if_pcn.c if_rl.c if_sf.cif_sis.c
if_sk.c if_ste.c if_ti.c if_tl.c if_vr.c if_wb.c if_xl.c
Nate Lawson
nate at root.org
Tue Apr 22 23:30:55 PDT 2003
On Mon, 21 Apr 2003, Warner Losh wrote:
> Modified files:
> sys/pci if_dc.c if_pcn.c if_rl.c if_sf.c if_sis.c
> if_sk.c if_ste.c if_ti.c if_tl.c if_vr.c
> if_wb.c if_xl.c
> Log:
> Use newly minted device_is_attached rather than device_is_alive to see
> if attach succeeded. device_is_alive just tells us that probe
> succeeded. Since we were using it to do things like detach net
> interfaces, this caused problems when there were errors in the attach
> routine.
>
> Symptoms of problem reported by: martin blapp
Thank you for finding and fixing this. For fxp, I was testing this case
by forcing the last call (bus_setup_irq()) to fail and loading/unloading
the module in a loop. Everything still worked ok but there was definitely
a leak in the busdma malloc pool. I'll see if this addresses that
problem.
-Nate
More information about the cvs-src
mailing list