cvs commit: src/sys/pci if_dc.c if_pcn.c if_rl.c if_sf.c if_sis.c if_sk.c if_ste.c if_ti.c if_tl.c if_vr.c if_wb.c if_xl.c

[Nate Lawson]

njl         2003/04/17 13:32:07 PDT

  FreeBSD src repository

  Modified files:
    sys/pci              if_dc.c if_pcn.c if_rl.c if_sf.c if_sis.c 
                         if_sk.c if_ste.c if_ti.c if_tl.c if_vr.c 
                         if_wb.c if_xl.c 
  Log:
  Revise attach/detach resource cleanup
  - Unconditionally call *_stop() if device is in the tree. This is to
    prevent callouts from happening after the device is gone. Checks for
    bus_child_present() should be added in the future to keep from touching
    potentially non-existent hardware in *_detach().  Found by iedowse at .
  - Always check for and free miibus children, even if the device is not in
    the tree since some failure cases could have gotten here.
  - Call ether_ifdetach() in the irq setup failure case
  - ti(4), xl(4): move ifmedia_init() calls to the beginning of attach so
    that ifmedia_removeall() can be unconditionally called on detach. There
    is no way to detect whether ifmedia has been initialized without using
    a separate variable (as tl(4) does).
  - Add comments to indicate assumptions of code path
  
  Revision  Changes    Path
  1.103     +12 -2     src/sys/pci/if_dc.c
  1.43      +15 -6     src/sys/pci/if_pcn.c
  1.97      +14 -4     src/sys/pci/if_rl.c
  1.55      +14 -4     src/sys/pci/if_sf.c
  1.73      +15 -6     src/sys/pci/if_sis.c
  1.60      +14 -4     src/sys/pci/if_sk.c
  1.51      +14 -4     src/sys/pci/if_ste.c
  1.77      +13 -5     src/sys/pci/if_ti.c
  1.82      +14 -4     src/sys/pci/if_tl.c
  1.70      +14 -4     src/sys/pci/if_vr.c
  1.59      +17 -5     src/sys/pci/if_wb.c
  1.142     +17 -10    src/sys/pci/if_xl.c