cvs commit: src/sys/conf options

[John Baldwin]

On 15-Apr-2003 Bruce Evans wrote:
> On Mon, 14 Apr 2003, Robert Watson wrote:
> 
>> rwatson     2003/04/14 14:45:12 PDT
>>
>>   FreeBSD src repository
>>
>>   Modified files:
>>     sys/conf             options
>>   Log:
>>   Add MAC_ALWAYS_LABEL_MBUF to options; this permits the administrator
>>   to force the allocation of MAC labels for all mbufs regardless of
>>   whether a configured policy requires labeling when the mbuf is
>>   allocated.  This can be useful it you anticipate loading a fully
>>   labeled policy after boot and don't want mbufs to exist without
>>   label storage, for performance measurement purposes, etc.  It also
>>   slightly lowers the overhead of m_tag labeling due to removing the
>>   decision logic.
> 
> This seems to be missing in NOTES.
> 
>>   While here, improve commenting of other MAC options.
> 
> This unimproves the commenting, since individual options should only be
> commented on in 1 place (not here).  This file shouldn't contain any
> comments except meta-comments about what to put in it and technical
> details.  There are good examples of these at the start of the file.
> More examples:
> 
>     # Do not add comments on individual options in this file!
>     # Put comments on options in NOTES, not here!
>     # These rules should go without saying - see commit history
> 
>>   Obtained from:  TrustedBSD Project
>>   Sponsored by:   DARPA, Network Associates Laboratories
>>
>>   Revision  Changes    Path
>>   1.388     +7 -1      src/sys/conf/options
> 
> Should be more like +1 -4 to remove the comments, or larger to move the
> options.  Options that use a prefix so that it is obvious what subsystem
> they are for are grouped naturally if they are sorted normally.  Here is
> an old patch that moves the MAC options and fixes a few of the other
> style bugs in this file.

Could you please commit this modulo the GEOM => NO_GEOM change?

-- 

John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/