cvs commit: src/libexec/talkd announce.c extern.h print.c table.c talkd.c

[Ruslan Ermilov]

On Thu, Apr 03, 2003 at 08:03:01AM -0800, David O'Brien wrote:
> On Thu, Apr 03, 2003 at 06:19:22PM +0300, Ruslan Ermilov wrote:
> > I can fix this:
> > 
> > %%%
> > Index: bsd.sys.mk
> 
> Would this be better?
> 
Hardly so.

> Index: bsd.sys.mk
> ===================================================================
> RCS file: /home/ncvs/src/share/mk/bsd.sys.mk,v
> retrieving revision 1.11
> diff -u -r1.11 bsd.sys.mk
> --- bsd.sys.mk	13 Nov 2002 13:49:29 -0000	1.11
> +++ bsd.sys.mk	3 Apr 2003 16:02:28 -0000
> @@ -24,17 +24,11 @@
>  .  if ${WARNS} > 3
>  CFLAGS		+=	-Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align
>  .  endif
> -.  if ${WARNS} > 4
> -CFLAGS		+=	-Wuninitialized
> -.  endif
> +#	XXX: the warning that was here became problematic.
> +#.  if ${WARNS} > 4

This hardly can be classified like a fix.  :-)

>  # BDECFLAGS
>  .  if ${WARNS} > 5
>  CFLAGS		+=	-ansi -pedantic -Wbad-function-cast -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls
> -.  endif
> -.  if ${WARNS} > 1 && ${WARNS} < 5
> -# XXX Delete -Wuninitialized by default for now -- the compiler doesn't
> -# XXX always get it right.
> -CFLAGS		+=	-Wno-uninitialized
>  .  endif
>  . endif
>  
This would be backwards.  -Wuninitialized is impled by -Wall,
and revision 1.5 was about to fix this.


Chees,
-- 
Ruslan Ermilov		Sysadmin and DBA,
ru at sunbay.com		Sunbay Software AG,
ru at FreeBSD.org		FreeBSD committer,
+380.652.512.251	Simferopol, Ukraine

http://www.FreeBSD.org	The Power To Serve
http://www.oracle.com	Enabling The Information Age
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20030404/574014c8/attachment.bin