cvs commit: src/libexec/talkd announce.c extern.h print.c table.c talkd.c

[Ruslan Ermilov]

On Thu, Apr 03, 2003 at 07:59:17AM -0800, David O'Brien wrote:
> On Thu, Apr 03, 2003 at 11:53:50AM +0300, Ruslan Ermilov wrote:
> > -.  if ${WARNS} > 4
> > +.  if ${WARNS} > 4 && !empty(CFLAGS:M-O*) && empty(CFLAGS:M-O0)
> >  CFLAGS		+=	-Wuninitialized
> >  .  endif
> 
> Why not just get rid of it totally?  We have this already:
> 
>     .  if ${WARNS} > 1 && ${WARNS} < 5
>     # XXX Delete -Wuninitialized by default for now -- the compiler doesn't
>     # XXX always get it right.
>     CFLAGS      +=  -Wno-uninitialized
>     .  endif
> 
> so we already know it is problematic.  OR rather than use:
> 
>     .  if ${WARNS} > 4 
>     CFLAGS      +=  -Wuninitialized
>     .  endif
> 
> use
> 
>     .  if ${WARNS} == 4 
>     CFLAGS      +=  -Wuninitialized
>     .  endif
> 
-Wuninitialized may be fixed at some point, but it will still
be unsupported without -O.  Why would we remove the support
for it if we can handle it right?  I find the -Wuninitialized
very useful, it saved me lot of crashes.


Cheers,
-- 
Ruslan Ermilov		Sysadmin and DBA,
ru at sunbay.com		Sunbay Software AG,
ru at FreeBSD.org		FreeBSD committer,
+380.652.512.251	Simferopol, Ukraine

http://www.FreeBSD.org	The Power To Serve
http://www.oracle.com	Enabling The Information Age
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20030403/2d37cf84/attachment.bin