cvs commit: src/libexec/talkd announce.c extern.h print.c table.c talkd.c

[Marcel Moolenaar]

On Thu, Apr 03, 2003 at 11:53:50AM +0300, Ruslan Ermilov wrote:
> > 
> How's this bugfix?
> 
> %%%
> Index: bsd.sys.mk
> ===================================================================
> RCS file: /home/ncvs/src/share/mk/bsd.sys.mk,v
> retrieving revision 1.12
> diff -u -r1.12 bsd.sys.mk
> --- bsd.sys.mk	31 Mar 2003 13:10:51 -0000	1.12
> +++ bsd.sys.mk	3 Apr 2003 08:48:40 -0000
> @@ -25,7 +25,7 @@
>  .  if ${WARNS} > 3
>  CFLAGS		+=	-Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align
>  .  endif
> -.  if ${WARNS} > 4
> +.  if ${WARNS} > 4 && !empty(CFLAGS:M-O*) && empty(CFLAGS:M-O0)
>  CFLAGS		+=	-Wuninitialized
>  .  endif
>  # BDECFLAGS
> %%%

Should work in most cases, but beware DEBUG_FLAGS. The above does not
catch the case where DEBUG_FLAGS is defined to something like "-O0 -g".
I think this is a reasonable use of DEBUG_FLAGS.

\begin{log}
dhcp01% setenv DEBUG_FLAGS "-O0 -g"
dhcp01% setenv CFLAGS -O
dhcp01% make
cc -O -mcpu=pentiumpro -I/usr/local/src/fpi/cpu/..  -O0 -g -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wuninitialized  -c decode.c
cc1: warnings being treated as errors
cc1: warning: -Wuninitialized is not supported without -O
*** Error code 1
\end{log} 

-- 
 Marcel Moolenaar	  USPA: A-39004		 marcel at xcllnt.net