cvs commit: src/sys/dev/fxp if_fxp.c if_fxpreg.h if_fxpvar.h
Maxime Henrion
mux at freebsd.org
Wed Apr 2 10:44:15 PST 2003
Nate Lawson wrote:
> On Wed, 2 Apr 2003, Maxime Henrion wrote:
> > Modified files:
> > sys/dev/fxp if_fxp.c if_fxpreg.h if_fxpvar.h
> > Log:
> > Convert the fxp(4) driver to the busdma API.
> >
> > This patch is rather big because I had to significantly redesign
> > the driver to make the busdma conversion possible. Most notably,
> > hardware and software structures were carefully splitted to get
> > rid of all the structs overlapping evilness.
>
> Nice! I have some locking patches for fxp that I'll post soon. It looks
> like some nice comments were removed in your diff. It would be good if
> you rewrote equivalent ones based on the change in behavior.
I can't figure out which comments your are talking about. Some comments
have been moved to other places where they belong now, and one comment
has been removed in if_fxpreg.h because it wasn't meaningful anymore.
Cheers,
Maxime
More information about the cvs-src
mailing list