cvs commit: ports/emulators/open-vm-tools Makefile distinfo pkg-plist

[Steve Wills]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/08/12 07:04, Michael Scheidell wrote:
> 
> 
> On 1/8/12 6:55 AM, Olli Hauer wrote:
>> On 2012-01-08 12:44, Michael Scheidell wrote:
> 
>>>> Did anyone test if vmhgfs.ko works with this version? It did
>>>> work in the previous version, but when I tested it with the
>>>> versions in PRs 160941 (which I think is older than the
>>>> version committed) and 163725 (this one is newer than the
>>>> version committed) and it didn't work in either of those two.
>>>> If it doesn't work, I think this should be reverted unless
>>>> there's some benefit to this newer version besides the higher
>>>> version number.
>>>> 
>>> actually, 160941 looks newer than the one I committed:
>>> 
>>> RELEASE_DATE=           2011.08.21 BUILD_VER=          471295
>>> 
>>> 
>>> and 163725 looks even newer:
>>> 
>>> RELEASE_DATE=           2011.12.20 BUILD_VER=          56230
>>> 
>>> 
>>> we really need a way to set 'blocks on' or 'depends on' in
>>> GNATS :-)
>>> 
>>> 
>>> I will revert, and close old pr as 'obsolete'.
>>> 
>>> I MIGHT have an ~IN~ at vmware, let me see if I can get them to
>>> 'own' this.  The threat of Zen is breathing down their backs.
>> 
>> Can you test the newer release from 2011-12-20 ? Reverting back
>> needs PORTEPOCH bump which should be avoided.
> steve willis says that 163725 doesn't work.
> 

And I can confirm that, as suspected, the 471268 version committed
works fine in ESXi. but has the same issue with hgfs in Fusion 4 that
both 471295 (PR 160941) and 562307 (PR 163725) have.

> how about this:
> 
> I mark it BROKEN right now, and see if I can't pull some strings
> at vmware to get to the bottom of this (figured our revert :    the
> Makefile at 1.5.5?  just do a cvs update -r 1.5.4?  takes them ALL
> in?
> 
> still, like BROKEN idea, maybe I can get help on this next week.
> 

I've attached the updated patch which lets the vmhgfs.ko module build
in a way that allows it to at least kldload properly. But note that
this module produces an instant panic on trying to mount an hgfs. If
we think we can find a solution quickly, then perhaps for now include
the updated patch, but don't install the hgfs module, so that the port
loses the hgfs feature, but hopefully only temporarily.

>> Snippet from the open-vm-tools mailing list. [snip]

Thanks, I hadn't thought to look there. I'll keep an eye on that list.
And of course, thanks for the quick response!

Steve
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (FreeBSD)

iQEcBAEBAgAGBQJPCcseAAoJEPXPYrMgexuhaUwIAI+gmAAL0/+zWZtGFH/AdTxK
R3NzuUE9V2NlCEZecugn4WDz5mI8j9aIhul1yu/cdohN8pK8mZCQbkKb3QZ6Oyqk
m5ClVVeJyFUZLLHz9qit8C53ClYvvDsZ21pgpT5NFL+g8EA75AY/2dwfwyiM3Eog
PYsaa2Pfz2CBEG0/ZGGLx0p0IETsCmvZpi8FayXB9bGM7UdgVJxr268xGMjN0cAp
oRxnbSQZpCFgIXYMfPibROlC0de1aWKWzhGByOgaopj0p4tw9fAyDHoYWUUOMD5b
EiGu+YlmlFtFV+FAzyDPfe1O41isGYiBNBv9qzA6nZlDq6oDAWPEdbcqM+tF/H4=
=/i7S
-----END PGP SIGNATURE-----
-------------- next part --------------
--- modules/freebsd/vmhgfs/Makefile.orig	2011-09-15 02:03:28.000000000 +0000
+++ modules/freebsd/vmhgfs/Makefile	2012-01-08 16:11:28.000000000 +0000
@@ -47,7 +47,7 @@
 .endif
 
 COMMON_HGFS_SRCS := debug.c
-COMMON_HGFS_SRCS := bdhandler.c
+COMMON_HGFS_SRCS += bdhandler.c
 COMMON_HGFS_SRCS += request.c
 COMMON_HGFS_SRCS += worker.c
 COMMON_HGFS_SRCS += fsutil.c
@@ -93,22 +93,7 @@
    CFLAGS += -Ishared
 .endif
 
-#
-# FreeBSD's kernel module build system defines a bunch of additional warning
-# flags for the compiler in addition to -Wall -Werror.  However, some of these,
-# like -Wredundant-decls, are overkill.  To get around this, I copied their list
-# of warning flags, but explicitly disabled a few.
-#
-CWARNFLAGS := -Wall
-CWARNFLAGS += -Werror
-CWARNFLAGS += -Wno-redundant-decls
-CWARNFLAGS += -Wnested-externs
-CWARNFLAGS += -Wstrict-prototypes
-CWARNFLAGS += -Wno-missing-prototypes
-CWARNFLAGS += -Wpointer-arith
-CWARNFLAGS += -Winline
-CWARNFLAGS += -Wcast-qual
-
 EXPORT_SYMS = NO
 
+.include <bsd.own.mk>
 .include <bsd.kmod.mk>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-vmhgfs-Makefile.sig
Type: application/octet-stream
Size: 287 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-ports/attachments/20120108/91aaf5a3/patch-vmhgfs-Makefile.obj