cvs commit: ports/security/ossec-hids-server Makefile ports/security/ossec-hids-server/files ossec-hids.in patch-src__init__ossec-local.sh

[Doug Barton]

1. The rc.d file needs a $FreeBSD$
2. Since it runs as an unprivileged user it should REQUIRE: LOGIN. Why
is it necessary to run earlier?
3. The ossechids_command() is not necessary. You could simply do (for
example): start_cmd="$command start"
4. Instead of touch/chown/chmod consider using install with the right
command line arguments in one go.


hth,

Doug


On 11/23/2011 14:26, Greg Larkin wrote:
> glarkin     2011-11-23 22:26:41 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     security/ossec-hids-server Makefile 
>     security/ossec-hids-server/files ossec-hids.in 
>   Added files:
>     security/ossec-hids-server/files 
>                                      patch-src__init__ossec-local.sh 
>   Log:
>   - Applied the startup script patch from PR ports/161524 to the local
>     installation type [1]
>   - Streamlined the rc.d file to use fewer functions
>   - Added a precmd to the rc.d file to ensure the proper ownership on
>     some queue files. OSSEC daemons don't properly chown them upon creation.
>   - Bumped PORTREVISION
>   
>   Reported by:    Albert Gabas <agabas at astabis.com> (via email) [1]
>   Feature safe:   yes
>   
>   Revision  Changes    Path
>   1.17      +4 -1      ports/security/ossec-hids-server/Makefile
>   1.4       +25 -15    ports/security/ossec-hids-server/files/ossec-hids.in
>   1.1       +11 -0     ports/security/ossec-hids-server/files/patch-src__init__ossec-local.sh (new)
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/security/ossec-hids-server/Makefile.diff?&r1=1.16&r2=1.17&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/security/ossec-hids-server/files/ossec-hids.in.diff?&r1=1.3&r2=1.4&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/security/ossec-hids-server/files/patch-src__init__ossec-local.sh
> 



-- 

		[^L]

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/