cvs commit: ports/www/chromium Makefile

Chris Rees crees at freebsd.org
Mon Aug 22 21:08:25 UTC 2011


On 22 Aug 2011 21:51, "Joseph S. Atkinson" <jsa at freebsd.org> wrote:
>
> On 08/21/2011 09:13, Chris Rees wrote:
>>
>>
>> On 21 Aug 2011 13:00, "Alexey Dokuchaev" <danfe at freebsd.org
>> <mailto:danfe at freebsd.org>> wrote:
>>  >
>>  > On Sun, Aug 21, 2011 at 11:52:14AM +0000, Alexey Dokuchaev wrote:
>>  > > On Sun, Aug 21, 2011 at 12:48:38PM +0100, Chris Rees wrote:
>>  > > > I'd agree on FILESDIR.
>>  > > >
>>  > > > Anyone have a problem with adding a section on
>>  > > > wiki/PortsLongtermTargets about ports that use PATCHDIR? This
>>  > > > inconsistency is a little strange.
>>  > >
>>  > > Oh, please do.  This inconsistency is not just strange, but rather
annoying.
>>  >
>>  > As for the strange part, it seems like historical left-over from times
when
>>  > ports had "patches" directory (I vaguelly recall the OpenBSD still
does it
>>  > these days).  Since FreeBSD had standardized on "files" long time ago,
bpm
>>  > should stop using PATCHDIR and replace it with FILESDIR).  Ditto for
the
>>  > ports, of course.
>>  >
>>
>> PR filed at http://www.freebsd.org/cgi/query-pr.cgi?pr=159970 thanks for
the
>> motivation ;)
>>
>> Chris
>>
>
> I will ping marcus and have him add a bit to portlint(1) and maybe check
for hardcoding of files/ as well.
>

Make a patch you lazy git :P

Chris


More information about the cvs-ports mailing list