cvs commit: ports/irc/ngircd Makefile ports/irc/ngircd/files ngircd.in

[Doug Barton]

Marcus Alves Grando wrote:
> mnag        2006-02-13 16:56:11 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     irc/ngircd           Makefile 
>   Added files:
>     irc/ngircd/files     ngircd.in 
>   Log:
>   - Use OPTIONS and add more options
>   - Add rc.d script
>   - Bump PORTREVISION
>   
>   PR:             93285  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=93285
>   Submitted by:   mnag
>   Approved by:    maintainer
>   
>   Revision  Changes    Path
>   1.23      +28 -26    ports/irc/ngircd/Makefile
>   1.1       +33 -0     ports/irc/ngircd/files/ngircd.in (new)
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/irc/ngircd/Makefile.diff?&r1=1.22&r2=1.23&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/irc/ngircd/files/ngircd.in

This looks good, just two small comments. First, this line is not needed:

: ${ngircd_flags=""}

Second, it's not needed (or desired) to add *_flags to command_args. rc.subr
calls the command like this:

$command $rc_flags $command_args

where rc_flags is the post-processed form of $name_flags.

hth,

Doug

-- 

    This .signature sanitized for your protection