cvs commit: ports/x11/xlockmore Makefile ports/x11/xlockmore/files
patch-pam-passwd.c patch-pam-xlock.c
Edwin Groothuis
edwin at FreeBSD.org
Mon Dec 12 13:18:51 PST 2005
edwin 2005-12-12 21:18:26 UTC
FreeBSD ports repository
Modified files:
x11/xlockmore Makefile
Added files:
x11/xlockmore/files patch-pam-passwd.c patch-pam-xlock.c
Log:
xlockmore port improvements patch
Some time ago I send PR about PAM support in xlockmore. Now
I spend some time to work on xlockmore. I found that PAM
works fine by default (with --enable-pam), but only with
modules that does not requires root rights to authenticate.
But almost all PAM configurations ends with pam_unix call.
Here is the trouble. xlock drops root privileges after
startup. I use BAD_PAM again to wrap this setuid(). IMHO,
usage of BAD_PAM is right in this case. Also abort trap was
fixed. Here was error in PAM_conv function. I'll send
explanations of changes and situation to xlock-discuss
mailing list later. May be fixes will be committed into
next release of xlockmore.
Here is attached diff against xlockmore port. It makes some
changes in Makefile and drops two patches to files dir.
New knobs added to Makefile and some old changed. Here is the
description:
- OPTIONS added for interactive configuration of xlockmore
(make config).
- WITH_PAM - enable common PAM support in xlock, but does not define
BAD_PAM. So PAM modules that does not require root rights can be used
(pam_pwdfile e.g.).
- WITH_BAD_PAM - enable WITH_PAM and define BAD_PAM in config.h after
'configure'. So all PAM modules can be used, including pam_unix.
- WITH_NICE_ONLY - enable only low-CPU modes. Good for old machines.
- WITH_BLANK_ONLY - enable only 'blank' mode. Can be useful in some
cases.
PR: ports/90276
Submitted by: Yuri Y. Bushmelev <jay-dev at simcom.ru>
Revision Changes Path
1.99 +35 -2 ports/x11/xlockmore/Makefile
1.1 +62 -0 ports/x11/xlockmore/files/patch-pam-passwd.c (new)
1.1 +17 -0 ports/x11/xlockmore/files/patch-pam-xlock.c (new)
More information about the cvs-ports
mailing list