cvs commit: ports/deskutils/gourmet Makefile

[Adam Weinberger]

Kirill Ponomarew wrote:
> krion       2005-08-16 09:14:43 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     deskutils/gourmet    Makefile 
>   Log:
>   Fix dependencies and build.
>   
>   Approved by:    portmgr (implicit)

This won't fix the build at all. Look at the pre-install: target. 
gourmet requires a python-enabled metakit, and the only way to achieve 
that is to have WITH_METAKIT_PYTHON=yes defined when building metakit. 
All you've accomplished here is ensuring that the port is still BROKEN, 
but in a different way.

Your change may look better from the standpoint of pointyhat logs, but 
in reality, gourmet's dependency is more logically on libmk4py.so than 
on libmk4.so.

The real issue lies within metakit. There is no python-enabled metakit 
slave port, and one cannot choose to enable python based solely upon 
whether python is already installed (you can only check for 
${PYTHON_CMD} after bsd.port.pre.mk, but you can only define WITH_PYTHON 
*before* bsd.port.pre.mk... python could really use a WANT_PYTHON switch).

I'd prefer to see this change backed out, but it doesn't make much 
difference either way. In the future, though, could you please run 
changes like this by me first? I recognize that you're doing your 
portmgrial duties here, but surely one of my maintainer-based rights is 
to challenge changes like this *before* they're committed.

# Adam


-- 
Adam Weinberger
adamw at magnesium.net || adamw at FreeBSD.org
adamw at vectors.cx    ||   adamw at gnome.org
http://www.vectors.cx