cvs commit: ports/print/pdflib Makefile pkg-plist ports/print/pdflib/files patch-configure ports/print/pdflib-perl Makefile

[Sunpoet Po-Chuan Hsieh]

On Fri, Jan 13, 2012 at 09:17:41AM +0000, Alex Dupre wrote:
> ale         2012-01-13 09:17:41 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     print/pdflib         Makefile pkg-plist 
>     print/pdflib-perl    Makefile 
>   Added files:
>     print/pdflib/files   patch-configure 
>   Log:
>   - Add forgotten patch
>   - Switch to OPTIONS
>   - Add Java bindings [1]
>   
>   Submitted by:   Oliver Brandmueller <ob at e-Gitt.NET> [1]
>   
>   Revision  Changes    Path
>   1.4       +1 -1      ports/print/pdflib-perl/Makefile
>   1.61      +29 -9     ports/print/pdflib/Makefile
>   1.9       +12 -0     ports/print/pdflib/files/patch-configure (new)
>   1.22      +5 -0      ports/print/pdflib/pkg-plist

Hi Alex,

I was confused by the conditional PERL OPTIONS.

.if defined(WITH_PERL) 
OPTIONS=        PERL "Build perl bindings" on 
.else 
OPTIONS=        PERL "Build perl bindings" off 
.endif 

If WITH_PERL defined somewhere (pdflib-perl, make.conf or portconf),
the perl option should already be turned on by options framework. It
seems that a default-off perl option (line 4) is enough.

Regards,
-- 
   Sunpoet Po-Chuan Hsieh <sunpoet at sunpoet.net> <sunpoet at FreeBSD.org>
           4096R/CC57E36B 8AD8 68F2 7D2B 0A10 7E9B 8CC0 DC44 247E CC57 E36B
                             http://people.FreeBSD.org/~sunpoet/pgpkeys.txt