cvs commit: ports/devel/pinba_engine Makefile distinfo ports/devel/pinba_engine/files patch-src__ha_pinba.cc

[Doug Barton]

On 1/11/2012 8:12 AM, Greg Larkin wrote:
> On 1/10/12 6:08 PM, Doug Barton wrote:

>> The correct fix is probably to remove that line and add something like
>> (untested):
> 
>> .if ${MYSQL_VER} == 52
>> MYSQL_PORTDIR=       ${PORTSDIR}/databases/mariadb-server
>> .else
>> MYSQL_PORTDIR=       ${PORTSDIR}/databases/mysql${MYSQL_VER}-server
>> .endif
> 
>> That should allow it to work with mariadb.
>
> Hi Doug,
> 
> The line "${NONEXISTENT}:${MYSQL_PORTDIR}:configure" has been there
> since the initial import,

I was only going by the latest version of 'cvs annotate,' I didn't do an
exhaustive search. Sorry if I created confusion about when/who, etc.

> and the ":configure" portion adheres to the
> description here:
> http://www.freebsd.org/doc/en/books/porters-handbook/makefile-depend.html#AEN2138.

Yeah, someone clued me in about that on IRC, but thanks. Just to be
clear, I am not concerned about how the port does its thing. My only
concern is that it work with mariadb.

>  Can you post the errors from the INDEX build?

/usr/ports/devel/pinba_engine (pinba_engine-2011.08.18_1) Error.
BUILD_DEPENDS /usr/ports/databases/mysql52-server -- dependency not found

But once again, that's just a symptom. If the user sets WITH_MYSQL_VER=
52 in their make.conf this port will not build.

> Since Pinba now supports MySQL 5.1.x+ and MariaDB 5.1.43+, the better
> solution may be to present options to the user to select the database
> backend,

Um, no, that's exactly what should _not_ be done. :) The ports
infrastructure already has a method for users to select what mysql
version they want to use. This port needs to be made to work with it.
That's all.

Do you have a philosophical objection to the snippet I pasted in my last
message? It's not pretty but I don't see why it wouldn't work, and
provide minimal disruption to the way the port is structured currently.

-- 

	You can observe a lot just by watching.	-- Yogi Berra

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/