cvs commit: ports/polish/kadu Makefile distinfo pkg-descr pkg-plist ports/polish/kadu/files patch-kadu-core__CMakeLists.txt patch-kadu-core_gadu_resolver.cpp patch-modules__docking__CMakeLists.txt patch-modules__idle__CMakeLists.txt patch-modules__kde_notify__CMakeLists.txt patch-modules__screenshot__CMakeLists.txt patch-modules__sound__CMakeLists.txt ...

[Paweł Pękala]

Dnia , o godz. 
Alexey Dokuchaev <danfe at FreeBSD.org> napisał(a):

> Still some issues with this port:

Thanks for your suggestions, I`m new here so they will help me improve
my contributions. Firstly I want to say that this is situation where I
was taking over maintaniership so there were two people (me and
former maintainer) working on update so different "styles" got mixed
etc.

> - First part of the makefile (delarative one) is badly indented;
> indentation should be reduced my one tabstop

Sometimes more indentation help readability, in this case you are right
it's too many ;-) When submitting updates to other people's ports my
rule is always to stick to their style of indentation, it may look
messy to me but may work for maintainer.

> - Bad spelling of Qt toolkit in COMMENT (it looks like port is
> QuickTime based now); also, " / " does not look too good, simple
> "and" would look better

Good catch. Project description is now "Internet Communicator" as they
gained ability to connect Jabber network so I can use this.
 
> %%%
>  LIB_DEPENDS=		enchant.1:${PORTSDIR}/textproc/enchant \
>  			gadu.3:${PORTSDIR}/polish/libgadu \
> +			idn:${PORTSDIR}/dns/libidn \
>  			qca.2:${PORTSDIR}/devel/qca \
>  			sndfile.1:${PORTSDIR}/audio/libsndfile
> %%%
> 
> Missing shlib version (notice that other libs have it).  While it
> technically not required, it's nice to have to be able to grep for
> when buming port revision of library consumer ports to chase shlib
> version bumps.

While I am with Doug at this one things could be more consistent - if
there are shlib versions they should be on all dependencies.

According to upstream version 0.10.0 will be released soon, I will
incorporate all mentioned things in that update.

Paweł