cvs commit: ports/archivers/p5-Archive-Any pkg-plist ports/archivers/p5-Archive-SimpleExtractor pkg-plist ports/archivers/p5-Compress-LZF pkg-plist ports/archivers/p5-Compress-LZO pkg-plist ports/archivers/p5-Compress-LZW pkg-plist ports/archiver

Alexey Dokuchaev danfe at FreeBSD.org
Fri Sep 24 08:39:54 UTC 2010


On Fri, Sep 24, 2010 at 12:49:58AM -0700, Stanislav Sedov wrote:
> If there going to be a standard, it should be documented first.  From my
> POV I can see a benefit of having a @comment in pkg-plist, as it allows
> one to find out what revision this file was.

Having RCS ident string embedded into a file generally considered good
thing to have, true.  However, we generally omit one from files like
distinfo or pkg-plist because of the low volatile nature thereof.  While
having it in Makefile header is certainly good and useful thing (e.g. it
is used in pointyhat build logs), instrumenting plist with @comment can
be controversial.  Since relatively low number of pkg-plist files use
it, I can understand why Philip decided to drop it.  (I'm talking only
about technical side of the issue; lack of review is different thing.)

I also support the idea of documenting either way after thorough review
by all interested parties and adding it to PH/portlint(1).

> Or changing all ports with dynamic pkg-lists to use static one just
> because most ports do this.

Bad example.  :-)  Both dynamic and static package lists are useful, as
both have their strong and weak sides (and benefits in questions here
are a lot more substantial than availability of ident information).

./danfe


More information about the cvs-all mailing list