cvs commit: ports/sysutils/socket/files patch-ag

Alexey Dokuchaev danfe at FreeBSD.org
Sat Sep 11 10:00:31 UTC 2010


On Fri, Sep 10, 2010 at 06:24:55AM +0000, Philip M. Gollucci wrote:
> On 09/10/10 03:32, Alexey Dokuchaev wrote:
> > Per PH section 4.4:
> > 
> > "Do not name your patches like patch-aa or patch-ab etc, always mention
> >  path and file name in patch names."
> 
> I had very good reasons for doing this:
> 
> 1) I didn't want to regen the existing patches patch-a*

Absolutely.  New rules apply only to new patches.

> 2) Doing #1 actually cause the patches not to apply in an
>    incredibly difficult manner.

Well, since #1 does not apply, there is not problem, right?

> 3) If it was a port I maintained instead of fixing a long timed out pr
>    I would have spent the extra effort and time to fix this.
> 
> How about instead of replying to 1/2 of everyone's commits you commit
> some of your own prs so I can reply to them ?

Sure, please feel free, I'm always open for feedback.  Commit stats can
be found e.g. at http://cia.vc/stats/author/<committer>

./danfe


More information about the cvs-all mailing list