cvs commit: src/usr.bin/su su.c

[John Baldwin]

On Thursday 07 June 2007 04:57:42 pm Alexey Dokuchaev wrote:
> On Tue, Sep 05, 2006 at 05:09:42PM +0000, Alexey Dokuchaev wrote:
> > On Tue, Sep 05, 2006 at 12:25:35PM -0400, John Baldwin wrote:
> > > On Sunday 03 September 2006 14:42, Slawa Olhovchenkov wrote:
> > > > On Tue, Jan 03, 2006 at 09:17:04AM +0000, Brian Somers wrote:
> > > > 
> > > > > brian       2006-01-03 09:17:04 UTC
> > > > > 
> > > > >   FreeBSD src repository
> > > > > 
> > > > >   Modified files:
> > > > >     usr.bin/su           su.c 
> > > > >   Log:
> > > > >   Fix the other su bug reintroduced two commits ago, namely
> > > > >   
> > > > >       $ su
> > > > >       % kill -STOP $$
> > > > >   
> > > > >   where su is executing (t)csh.  csh's job handling is a little more
> > > > >   special than that of (a)sh, bash and even zsh and blows up a 
little
> > > > >   more spectacularly.  This modification restores the original 
mucking
> > > > >   about with the tty pgrp, but is careful to only do it when su (or
> > > > >   su's child) is the foreground process.
> > > > >   
> > > > >   While I'm here, fix a STDERR_FILENO spelling as suggested by bde.
> > > > 
> > > > This is break 'make config' in ports tree:
> > > > 
> > > > > make config
> > > > ===>  Switching to root credentials to create /var/db/ports/glib20
> > > > ===>  Returning to user credentials
> > > > 
> > > > Suspended (tty output)
> > > 
> > > I've noticed weirdness where the tty seems to get into a funk where 
every su
> > > goes into suspended mode, such that I have to 'fg' and then enter the 
root
> > > password.  Then it will keep chugging along until the next su.  This 
seems
> > > to imply that the tty state is hosed somehow.
> > 
> > I can say that this "Suspended (tty output)" and requirement to do "fg"
> > annoys me for several months already (I'm using tcsh(1)).  I've also
> > noticed that I have to press Enter after every command in ispell(1), but
> 
> This rather annoying thing keeps happening to me up to rairly recent
> -CURRENT.
> 
> Any further clues I can provide you guys?

I still see it too, highly annoying.  I've even seen it during boot (rc.d 
scripts) where 'Ctrl-T' fails to find a foreground process group, etc.

-- 
John Baldwin