cvs commit: doc/en_US.ISO8859-1/books/porters-handbook book.sgml

[chinsan]

On 7/20/07, Pav Lucistnik <pav at freebsd.org> wrote:
> Chin-San Huang píše v pá 20. 07. 2007 v 12:46 +0000:
> > chinsan     2007-07-20 12:46:12 UTC
> >
> >   FreeBSD doc repository
> >
> >   Modified files:
> >     en_US.ISO8859-1/books/porters-handbook book.sgml
> >   Log:
> >   - Fix typo.
> >
> >   "If a port insists on linking -lpthread or -lc_r directly, patch it to use
> >   PTHREAD_LIBS variable provided by the ports framework."
> >
> >   Noticed by:     kevlo
> >
> >   Revision  Changes    Path
> >   1.858     +1 -1      doc/en_US.ISO8859-1/books/porters-handbook/book.sgml
>
> That's actually not a typo. The text should read
>
>   on linking -pthread, -lpthread or -lc_r
>
> --
> Pav Lucistnik <pav at oook.cz>
>               <pav at FreeBSD.org>
>
> Sword ownership rights have been under heavy fire since they were
> determined to be the leading cause of death during the Siege of Acre
> in the third crusade.

Hi, Pav:

The Original:
     @${REINPLACE_CMD} -e 's|-pthread|${PTHREAD_LIBS}|' ${WRKSRC}/configure
The patched:
     @${REINPLACE_CMD} -e 's|-lpthread|${PTHREAD_LIBS}|' ${WRKSRC}/configure

Since "PTHREAD_LIBS?= -pthread", so why we should replace it again?
Therefore, it was guessed as a typo of "-lpthread" instead of "-pthread".
Because PTHREAD_LIBS = -pthread. :)

The following text is just a quote
"If a port insists on linking -lpthread or -lc_r directly, patch it to use
 PTHREAD_LIBS variable provided by the ports framework."


- chinsan