cvs commit: ports/net/linux-nx-client Makefile distinfo pkg-plist ports/net/linux-nx-client/files patch-nxclient-admin.desktop patch-nxclient-help.desktop patch-nxclient-wizard.desktop patch-nxclient.desktop

[Gabor Kovesdan]

Alexander Leidinger schrieb:
> Quoting Gabor Kovesdan <gabor at FreeBSD.org> (from Thu, 25 Jan 2007 
> 23:00:53 +0000 (UTC)):
>
>> gabor       2007-01-25 23:00:52 UTC
>>
>>   FreeBSD ports repository
>>
>>   Modified files:
>>     net/linux-nx-client  Makefile distinfo pkg-plist
>>   Removed files:
>>     net/linux-nx-client/files patch-nxclient-admin.desktop
>>                               patch-nxclient-help.desktop
>>                               patch-nxclient-wizard.desktop
>>                               patch-nxclient.desktop
>>   Log:
>>   - Update to 2.1.0
>>   - Move to LINUXBASE
>
> I had a look at the changes and the entire plist. I think this belongs 
> into localbase instead. linuxbase is reserved for infrastructure ports 
> (e.g. libs). Stuff which is used directly by users is supposed to go 
> to localbase. The plist shows systems independend stuff in "ordianary" 
> directories, and the linux object specific stuff in a directory 
> (lib/linux-nx-client/) which makes it very hard to mistake it as 
> FreeBSD native stuff (it also contains some pictures, which don't 
> belong here but into share instead, but this is not high priority 
> stuff to fix). So I suggest to move it into localbase instead.
>
>>   - Add USE_LDCONFIG
>
> This is not ncessary here at all, as the linux libs are private ones 
> and are not in the default search path of the linux ldconfig.
>
Ah ok, for me the only reason for moving it to LINUXBASE was using linux 
ldconfig, but since it's not required I can easily move it to LOCALBASE, 
thanks for pointing this out. I'll fix soon.

Regards,

Gabor