cvs commit: ports/security/racoon2 Makefile pkg-plist ports/security/racoon2/files patch-samples-Makefile.in patch-samples-rc.d-iked.in

[Doug Barton]

Munechika SUMIKAWA wrote:
> sumikawa    2006-06-07 07:33:36 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     security/racoon2     Makefile pkg-plist 
>     security/racoon2/files patch-samples-Makefile.in 
>   Added files:
>     security/racoon2/files patch-samples-rc.d-iked.in 
>   Log:
>   clean up startup scripts.

One problem, one suggestion. :)  First, what you really want to do is change
rcvar:

rcvar=`set_rcvar`

Which will work on both FreeBSD and NetBSD. In FreeBSD you would be better
off deleting the required_vars line (which I don't think is useful in NetBSD
either, but I wouldn't swear to it). If I were you, I'd suggest both of
these changes upstream.

The suggestion would be to do these kinds of very small and obvious changes
using sed in the Makefile, as opposed to using patches, since the former
causes less repo bloat, but that's a style issue.

hth,

Doug

>   PR:             ports/91312  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=91312
>   Reported by:    Vivek Khera <vivek at khera.org>
>   
>   Revision  Changes    Path
>   1.44      +1 -1      ports/security/racoon2/Makefile
>   1.4       +2 -3      ports/security/racoon2/files/patch-samples-Makefile.in
>   1.1       +11 -0     ports/security/racoon2/files/patch-samples-rc.d-iked.in (new)
>   1.10      +0 -1      ports/security/racoon2/pkg-plist
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/security/racoon2/Makefile.diff?&r1=1.43&r2=1.44&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/security/racoon2/files/patch-samples-Makefile.in.diff?&r1=1.3&r2=1.4&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/security/racoon2/files/patch-samples-rc.d-iked.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/security/racoon2/pkg-plist.diff?&r1=1.9&r2=1.10&f=h
> 


-- 

    This .signature sanitized for your protection