cvs commit: ports/news/newscache Makefile pkg-plist ports/news/newscache/files newscache.sh.in

[Doug Barton]

Edwin Groothuis wrote:
> edwin       2006-01-04 21:49:12 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     news/newscache       Makefile pkg-plist 
>   Added files:
>     news/newscache/files newscache.sh.in 
>   Log:
>   Update port: news/newscache , Added rc script
>   
>           news/newscache is lacking an rc script, so I hacked this one up
>   
>   PR:             ports/91319  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=91319
>   Submitted by:   Arjan Koole <arjan at blackoak.net>
>   
>   Revision  Changes    Path
>   1.21      +9 -5      ports/news/newscache/Makefile
>   1.1       +26 -0     ports/news/newscache/files/newscache.sh.in (new)
>   1.5       +1 -0      ports/news/newscache/pkg-plist
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/news/newscache/Makefile.diff?&r1=1.20&r2=1.21&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/news/newscache/files/newscache.sh.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/news/newscache/pkg-plist.diff?&r1=1.4&r2=1.5&f=h

It would be better to replace the SUB_FILES line in the Makefile with:

USE_RC_SUBR=    ${PORTNAME}.sh

This provides several benefits in the short term. It would obviate the need 
for the post-install target and the pkg-plist entry, as the USE_RC_SUBR 
macro handles that stuff (as well as the SUB_FILES stuff) for you 
automatically. In the long term, we're going to add even more support for 
good things in the USE_RC_SUBR code, so it's a good idea to move that 
direction now.

The script itself looks very well thought out, and takes advantage of the 
rc.subr mechanisms well, so congrats on that bit, and thanks for this addition.

Doug

-- 

     This .signature sanitized for your protection