cvs commit: src/sys/dev/cp if_cp.c

[Roman Kurakin]

Hi,

David O'Brien:

>On Thu, Oct 27, 2005 at 12:01:29AM +0400, Roman Kurakin wrote:
>  
>
>>David O'Brien:
>>    
>>
>>>On Tue, Oct 25, 2005 at 02:10:50PM +0400, Roman Kurakin wrote:
>>>      
>>>
>>>>The commit log didn't state what was the problem variable forward 
>>>>declaration or/and function
>>>>forward declaration.
>>>>        
>>>>
>>>Since you became a committer 2003/12/18, I guess you haven't been part of
>>>FreeBSD when we've worked on a GCC compiler upgrade.  We make these type
>>>of changes to make a new version of GCC build FreeBSD.  The other choice
>>>is to disconnect these drivers from the build.  The commits done where
>>>typical of what's been done for the past decade.
>>>
>>>      
>>>
>>Please provide detailed technical information what is wrong in my
>>change of your commit.
>>    
>>
>
>Instead of arguing this with you as it is probably fruitless.
>If you're going to pull the "maintainer" card, then please have these
>drivers moved to src/sys/contrib and note them in src/MAINTAINERS.  That
>way this isn't a landmine for other committers to step on.
>
I do not want to buffer development proccess since I cant guarantee 
quick response
at any random time. From my point of view for most of commits there is 
enough
post-commit review. Since all (most) changes go through current I have 
enough time
to fix them in case of wrong (from my point of view) change.

>>I do not want to list them in src/MAINTAINERS cause I think it is
>>better to allow any commits.
>>Cases such this one is rare.
>>    
>>
>
>Rare or not, they can occur so why not take easy steps to avoid strife?
>
If you insist I could add myself to MAINTAINERS with post-commit review
just to inform that I am exist. But I doubt that this will close all 
rare cases.

rik