cvs commit: ports/games/doom Makefile ports/games/doom/files patch-ag patch-sndserv__soundsrv.c patch-sndserv__wadread.c

[Edwin Groothuis]

On Mon, Oct 10, 2005 at 10:49:37PM -0400, Adam Weinberger wrote:
> But OTOH, using a REINPLACE saves you from having to regenerate patches 
> for every single update. It might make initial patching a bit trickier, 
> but it can prevent unexpected problem from popping up in the future.
> 
> In my eyes, saying that people shouldn't use pre-patch instead of patch 
> files to prevent difficult sequential patching is akin to saying that 
> people shouldn't own cars because they might slam their fingers in the 
> door ::P

Patches for ports which replace anything but FreeBSD specific things 
(and then paths are the only things I can think about) should be 
fed upstream and removed in the next upgrade.

Just doing blind drive-by replacements for things which went wrong
in the past is not quality.

And with this I stop argueing about it. I gave good reasons in the
first reply.

Edwin
-- 
Edwin Groothuis      |            Personal website: http://www.mavetju.org
edwin at mavetju.org    |          Weblog: http://weblog.barnet.com.au/edwin/