cvs commit: ports/games/quake2lnx Makefile distinfo pkg-message pkg-plist ports/games/quake2lnx/files extra-patch-src_rogue_g__local.h extra-patch-src_rogue_q__shared.c extra-patch-src_xatrix_q__shared.c patch-Makefile patch-src::game::g_phys.c patch-src::linux::gl_glx.c patch-src::linux::rw_in_svgalib.c ...

[Alexey Dokuchaev]

On Fri, Nov 18, 2005 at 07:46:11AM +1100, Edwin Groothuis wrote:
> On Thu, Nov 17, 2005 at 01:31:08PM +0000, Alexey Dokuchaev wrote:
> > >  * Change patch names (using "_" instead of "::"), and also some patches.
> > 
> > I was under impression that we do not do this for patches already there,
> > this convention typically should be only applied to new patch files.
> 
> I was aware of this rule, but I was slightly distracted while I
> commited the first bunch of PRs and went "oh shit" when I saw the
> files getting in. The good news is that I checked the rest of the
> PRs for this before they went in.
> 
> I'm even going to ask for a repocopy I thnk to call it linux-quake2
> to get in line with other quake ports, is that okay?

Probably not.  Quake2-LNX project is further Quake II code clean up done
by the guys at icculus.org (I'm one of them actually).  It is natively
supported under FreeBSD, so there's no `linux-' prefix needed here.

There's also a reason not to call it merely `quake2' since that would
imply that the port is actually based off original (genuine) Quake II
source code released by id software in 2000.

There is, actually, a lot of things to think about WRT quake-based
ports.  Since the code is generally available, number of projects
usually get spawned, and each of different quality, portability and
features.  There's very little use to commit port of original Quake II
code, since it's so out of date and full of bugs.  This is the main
reasons why I decided to hold off and wait to see what happens to Quake
III Arena source code, to see if maybe some promising party would step
out and start cleaning it up.  You've decided to commit id's code.
Whatever.  I just hope security bugs won't pop up too often, since
technically no one is responsible to fix them.  It's just a reference
code, and that's why I thinks it's silly to commit it.

./danfe