cvs commit: ports/Mk bsd.php.mk ports/accessibility/at-spi Makefile ports/accessibility/dasher Makefile ports/accessibility/gail Makefile ports/accessibility/gnomemag Makefile ports/accessibility/gnomespeech Makefile ...

[Ade Lovett]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


On Nov 14, 2005, at 23:50 , Kris Kennaway wrote:
> Um, this is the poster child for something that should have been run
> through pointyhat first.  I do hope you didn't screw up ;-)

I disagree.  Look carefully at the top of bsd.autotools.mk.  Notice  
how all the old variables set a USE_AUTOTOOLS_COMPAT variable which  
is processed in *exactly*the*same*way* as USE_AUTOTOOLS.

*That* is the heavy-lifting part, which *was* run through pointyhat.

Well, actually these three lines:
.for item in ${USE_AUTOTOOLS}
AUTOTOOL_${item:C/^([^:]+).*/\1/}${item:M*\:*\:*:C/^[^:]+:[^:]+:([^:] 
+)/_\1/}= $
{item:C/^[^:]+:([^:]+).*/\1/}
.endfor

This was merely a mechanical process to essentially sweep the tree,  
looking for ports that had USE_AUTOTOOLS_COMPAT defined, and again  
mechanically change the Makefile to remove all the old variables, and  
replace with:

	USE_AUTOTOOLS= (output from make -V USE_AUTOTOOLS_COMPAT)

Think of this as the equivalent to the $Id$ -> $FreeBSD$ tag change a  
while back.  It really is a no-op.

Hell, I even backed out the .warning in bsd.autotools.mk so as *not*  
to get email from you about INDEX-4 failing, even though my 7.x boxes  
absolutely refuse to build a 4.x tinderbox:

===> usr.sbin/bootparamd/bootparamd
cc -O -pipe  -DTFTP_DIR=\"/tftpboot\" -I.    -c /tbox/jails/4-i386/ 
src/usr.sbin/bootparamd/bootparamd/bootparamd.c
/tbox/jails/4-i386/src/usr.sbin/bootparamd/bootparamd/bootparamd.c:  
In function `bootparamproc_whoami_1':
/tbox/jails/4-i386/src/usr.sbin/bootparamd/bootparamd/bootparamd.c: 
47: number of arguments doesn't match prototype
bootparam_prot.h:78: prototype declaration
/tbox/jails/4-i386/src/usr.sbin/bootparamd/bootparamd/bootparamd.c:  
In function `bootparamproc_getfile_1':
/tbox/jails/4-i386/src/usr.sbin/bootparamd/bootparamd/bootparamd.c: 
112: number of arguments doesn't match prototype
bootparam_prot.h:81: prototype declaration
[...]

You, sir, have not enough faith :)  I can *guarantee* this has gone  
through way more testing, in orders of magnitude less time, than  
pointyhat could ever begin to achieve.

- -aDe

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Darwin)

iD8DBQFDeZdvpXS8U0IvffwRAu20AJ0XivePE/jcrg5XemGc8yhY6UjdeQCeL7jK
v56rNj0xK5Aui1Jzwb9fBt4=
=d8r+
-----END PGP SIGNATURE-----