cvs commit: ports/archivers/gzip Makefile ports/archivers/ucl Makefile ports/archivers/lzop Makefile ports/archivers/cabextract Makefile ports/archivers/dact Makefile ports/archivers/star Makefile ports/archivers/arj Makefile ports/archivers/tardy ...

[Michael Nottebrock]

On Tuesday, 12. April 2005 07:56, David O'Brien wrote:

> > The porter's handbook, section 5.11 has an example that uses
> > MACHINE_ARCH, which is the template for a lot of MACHINE_ARCH usage in
> > ports,
>
> I wondered how this got copied around so many times.
>
> > including a few places your commit missed, like bsd.gnome.mk,
> > bsd.kde.mk, bsd.gnustep.mk and, most importantly, bsd.port.subdir.mk
> > and bsd.port.mk itself (for setting CONFIGURE_TARGET(!)).
>
> I purposefully didn't touch Mk/*.mk.  I have to assume the authors of
> them got it right. :-)

Well, you did however change ports that do nothing but mimic what bsd.ports.mk 
does (like audio/arts and x11/kdelibs3, which is why I noticed at all)... 

Anyway: If the usage of MACHINE_ARCH for setting the build-target of 
autoconf-generated configure scripts is indeed wrong and possibly harmful, 
this would affect a *very* large number of ports and your big commit would 
have fixed only a comparatively small number.

-- 
   ,_,   | Michael Nottebrock               | lofi at freebsd.org
 (/^ ^\) | FreeBSD - The Power to Serve     | http://www.freebsd.org
   \u/   | K Desktop Environment on FreeBSD | http://freebsd.kde.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20050412/89238031/attachment.bin