cvs commit: src/sbin/mount mntopts.h mount.8 mount.c src/sbin/mount_std mount_std.8

[Poul-Henning Kamp]

In message <20041130192316.GB3845 at ip.net.ua>, Ruslan Ermilov writes:

>> The reason I did not remove MNT_NODEV but only #defined it to zero was
>> to make it silently ignored.
>> 
>To make it silently ignored, you should have left it with its old value.
>Most operations with MNT_* constants are "bitwise AND", and so zero was
>not a good choice.

I tried to find my copy of "Bitmaps for dummies" to check what
you're saying but I can't find it right now, still, I'm very sure
that you are wrong, I just don't have the book to prove it.

Most operations on MNT_* are "bitwise OR" and a zero is perfectly OK.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.