cvs commit: ports/math/gnuplot Makefile

[Kirill Ponomarew]

Hi,

On Mon, Jun 28, 2004 at 02:01:54AM +0200, Pav Lucistnik wrote:
 
> In the unattended build, when no OPTIONS dialog is displayed, you don't
> have any WITH* and WITHOUT* variables set. Your port should behave as if
> default values were selected.
> 
> OPTIONS=	OPTION "foo" on
> 
> Default is to have OPTION on. When no WITH/WITHOUT* variables are
> generated, your test
> 
> .if defined(WITH_OPTION)
> 
> will fail. That's now the default you wanted. If you check instead
> 
> .if !defined(WITHOUT_OPTION)
> 
> it will work correctly in case OPTIONS were not processed. This nicely
> demonstrates in unattended build on packages on Bento, for example.
> 
> > Also, why wasn't the PR assigned to the maintainer (me :)?
> 
> Ask krion :)

Yeah, I should dress up my pointyhat for that ;)

-Kirill
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-all/attachments/20040628/00a304d9/attachment-0001.bin