cvs commit: src/sys/sys malloc.h src/sys/kern kern_malloc.c
src/sys/vm vm_contig.c vm_page.h
Garance A Drosihn
drosih at rpi.edu
Mon Jul 19 10:22:45 PDT 2004
At 9:25 AM -0400 7/19/04, John Baldwin wrote:
>On Monday 19 July 2004 06:39 am, Brian Fundakowski Feldman wrote:
> >
> > Aye, I didn't feel totally comfortable saying "Reviewed by:" since
> > that was a while ago, ...
>
>For future reference: In this case I usually add a line along the
>lines of:
>
>Reviewed by: bde (an earlier version)
>
>Which is both truthful and avoids the ensuing flamewar due to
>the appearance of an unreviewed driveby. :)
This sounds like a good method to follow.
Another thing to say is "by silence on freebsd-blah", so that
you document that others had a chance to review it, but no one
picked up on the opportunity.
--
Garance Alistair Drosehn = gad at gilead.netel.rpi.edu
Senior Systems Programmer or gad at freebsd.org
Rensselaer Polytechnic Institute or drosih at rpi.edu
More information about the cvs-all
mailing list