cvs commit: src/libexec/tftpd tftpd.c

David Schultz das at FreeBSD.ORG
Thu Jul 1 20:17:45 PDT 2004


On Wed, Jun 30, 2004, Christian S.J. Peron wrote:
> csjp        2004-06-30 18:58:19 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     libexec/tftpd        tftpd.c 
>   Log:
>   The call to setuid(2) subsequently causes setgroups(2) to fail. setgroups(2)
>   requires super-user access in order to complete successfully.
>   Move setgroups(2) to execute before setuid(2) so that it is successful.

Error checks would also be appropriate here, and would have
caught the bug.


More information about the cvs-all mailing list