cvs commit: ports/Mk bsd.port.mk

[Adam Weinberger]

>> (01.23.2004 @ 1940 PST): Daniel Eischen said, in 1.6K: <<
> On 23 Jan 2004, Adam Weinberger wrote:
> 
> > >> (01.23.2004 @ 1930 PST): Daniel Eischen said, in 0.7K: <<
> > > On 23 Jan 2004, Adam Weinberger wrote:
> > > 
> > > > >> (01.23.2004 @ 1731 PST): Daniel Eischen said, in 0.3K: <<
> > > > > deischen    2004/01/23 14:31:36 PST
> > > > > 
> > > > >   FreeBSD ports repository
> > > > > 
> > > > >   Modified files:
> > > > >     Mk                   bsd.port.mk 
> > > > >   Log:
> > > > >   Make PTHREAD_LIBS and PTHREAD_CFLAGS conditional.  Also remove
> > > > >   -D_THREAD_SAFE from PTHREAD_CFLAGS when it isn't needed.
> > > > >   
> > > > >   Revision  Changes    Path
> > > > >   1.482     +3 -3      ports/Mk/bsd.port.mk
> > > > >> end of "cvs commit: ports/Mk bsd.port.mk" from Daniel Eischen <<
> > > > 
> > > > Was this change approved by portmgr?
> > > 
> > > Not explicity, but portmgr is well aware of what's going on
> > > (hint: s/-lc_r/-lpthread).
> > >> end of "Re: cvs commit: ports/Mk bsd.port.mk" from Daniel Eischen <<
> > 
> > I was going to make a comment about not recalling any messages to
> > portmgr@ about this, but I think it's a case of seeing something so much
> > that you cease to see it anymore. ::P
> 
> Well, I admit I'm at fault here.  I didn't notice the big friggin'
> notice at the beginning of the file:
> 
>   # DO NOT COMMIT CHANGES TO THIS FILE BY YOURSELF, EVEN IF YOU DID NOT GET
>   # A RESPONSE FROM THE MAINTAINER(S) WITHIN A REASONABLE TIMEFRAME! ALL
>   # UNAUTHORISED CHANGES WILL BE UNCONDITIONALLY REVERTED!
> 
> portmgr has been CC'd in all our email, but I never explicitly asked
> for permission to do this specific change.
> 
> If you want, I can back it out.
>> end of "Re: cvs commit: ports/Mk bsd.port.mk" from Daniel Eischen <<

I cannot speak for portmgr, but I will say that backouts have been
requested in every other instance of this that I've seen.

Were I you, I'd probably do a pre-emptive backout.

But again, I cannot speak for portmgr on this.

# Adam


--
Adam Weinberger
adam at vectors.cx // adamw at FreeBSD.org // adamw at magnesium.net
http://www.vectors.cx