cvs commit: src/sys/fs/devfs devfs_rule.c

[Mike Makonnen]

On Thu, Jan 22, 2004 at 08:28:41AM +0000, Colin Percival wrote:
> At 07:49 22/01/2004, Mike Makonnen wrote:
> >On Wed, Jan 21, 2004 at 08:43:29AM -0800, Colin Percival wrote:
> >>   Allow devfs path rules to work on directories.  Without this fix,
> >>   devfs rule add path fd unhide
> >>   is a no-op, while it should unhide the fd subdirectory.
> >
> >Does this affect /etc/defaults/devfs.rules?
> 
>   No, but we might want to change devfs.rules.
> 
> >I am assuming that the 'add hide' in the first ruleset will now also
> >hide /dev/fd (where it previously didn't).
> 
>   The 'add hide' was always hiding /dev/fd.  It just wasn't possible
> to unhide it without unhiding everything.  (devfs_rule_matchpath is
> only called if the rule specifies a path; prior to this fix, it would
> always return "no, this doesn't match" when applied to a directory.)
> 
> >In that case will the
> >'add path fd/* unhide' in a later rule unhide the fd/ directory? Does
> >it need a separate 'add fd unhide'?
> 
>   Given that 'add path fd/* unhide' currently unhides entries within
> a hidden directory, it would probably makes sense to add a separate
> 'add path fd unhide'. :)

Please do so then. Thanks.

Cheers.
-- 
Mike Makonnen  | GPG-KEY: http://www.identd.net/~mtm/mtm.asc
mtm at identd.net | Fingerprint: 00E8 61BC 0D75 7FFB E4D3  6BF1 B239 D010 3215 D418
mtm at FreeBSD.Org| FreeBSD - Unleash the Daemon !