cvs commit: src/sys/kern kern_descrip.c

[Dag-ErlingSmørgrav]

Robert Watson <rwatson at FreeBSD.org> writes:
> It sounds like this is an API problem, and is probably what we
> should fix.  I've found WITNESS an invaluable debugging tool for
> locking, and when programming on systems without it, it's a very
> painful experience (i.e., debugging lock orders on Darwin).  You've
> also pointed out that the extra locking work being done is actually
> unnecessary, so maybe we just need an _unlocked() version of the
> API, or changes elsewhere?

The only case in which the locking is unnecessary is when initializing
a new struct filedesc.  In all other cases it is required.  Creating
an unlocked version of the API would require duplicating a lot of
code, for very little gain.

DES
-- 
Dag-Erling Smørgrav - des at des.no