cvs commit: ports/irc/insub pkg-plist

[Adam Weinberger]

Pav Lucistnik wrote:
> Alfred Perlstein píše v pá 17. 12. 2004 v 06:18 -0800:
> 
>>* Pav Lucistnik <pav at FreeBSD.org> [041217 01:22] wrote:
>>
>>>Alfred Perlstein p??e v ?t 16. 12. 2004 v 18:51 +0000:
>>>
>>>>alfred      2004-12-16 18:51:14 UTC
>>>>
>>>>  FreeBSD ports repository
>>>>
>>>>  Modified files:
>>>>    irc/insub            pkg-plist 
>>>>  Log:
>>>>  /usr/local/share/cows is usually not empty because a prerequesite of
>>>>  this port installs file in there.  So replace the @dirrm with
>>>>  "@unexec rmdir %D/share/cows 2>/dev/null || true" as other ports
>>>>  do.  I don't like this, but I don't know what else would work,
>>>>  it would be nice if this "feature" was implemented as a builtin
>>>>  to the package system.
>>>
>>>Is this software supposed to have the original cowsay files (those
>>>provided by cowsay port) installed at the runtime?
>>>
>>>If yes, then you should add cowsay to RUN_DEPENDS and then you could
>>>remove handling of share/cows directory from plist completely, because
>>>cowsay port (dependency) would handle it.
>>
>>Yes, but it installs its own cows...
>>  is that ok?
> 
> 
> Well, depends. I guess cows from the other package are not doing any
> harm?

Cowsay needs to be part of the RUN_DEPENDS anyway. Otherwise, you have a 
bunch of cow files around with nothing that can use them. Besides, 
cowsay isn't actually part of the build, anyway.

Furthermore, the @unexec rm %D/share/cows 2>/dev/null|| true should be 
added to cowsay's pkg-plist, not insub's.

# Adam


-- 
Adam Weinberger
adamw at magnesium.net || adamw at FreeBSD.org
adamw at vectors.cx    ||   adamw at gnome.org
http://www.vectors.cx