cvs commit: src/usr.sbin/pppd cbcp.c

[Xin LI]

delphij     2004-12-06 15:49:52 UTC

  FreeBSD src repository

  Modified files:
    usr.sbin/pppd        cbcp.c 
  Log:
  Correct two bugs that may result in incorrect CBCP response for
  administrator specified number.
  
  The implementation in our version transmits extra zero byte that is a
  violation of the Microsoft PPP Callback Control Protocol section 3.2[1].
  This can lead to incorrect behavior on certain devices, as reported
  in bin/50613.
  
  Confirmed with: cbcp.c in ppp's cvs, rev. 1.4 and 1.15 [2]
  
  Submitted by:   Dmitry Pryanishnikov <dmitry at atlantis.dp.ua>
  PR:             bin/50613
  
  [1] http://www.dsl.gr.jp/~manabe/PPxP/doc/Standards/draft-gidwani-ppp-callback-cp-00.txt
  [2] http://cvs.samba.org/cgi-bin/cvsweb/ppp/pppd/cbcp.c
      http://www.samba.org/cvs.html
  
  Revision  Changes    Path
  1.7       +3 -5      src/usr.sbin/pppd/cbcp.c