cvs commit: src/sys/pci if_ste.c

[Alexey Dokuchaev]

On Thu, Apr 01, 2004 at 09:42:41AM +0300, Ruslan Ermilov wrote:
> On Wed, Mar 31, 2004 at 01:47:16PM -0800, Nate Lawson wrote:
> > On Wed, 31 Mar 2004, Ruslan Ermilov wrote:
> > >   Modified files:
> > >     sys/pci              if_ste.c
> > >   Log:
> > >   Under a heavy RX load, at least with D-Link DFE-550TX adapters,
> > >   the driver's RX ring head may fall behind the chip, causing the
> > >   stuck traffic, disordered packets, etc.  Work around this by
> > >   adopting the technique of resyncing RX head used in dc(4) and
> > >   xl(4) drivers, but do it in a slightly different place to reduce
> > >   the number of resyncs needed.
> > >
> > >   Also, set the NIC's RX polling period to a more meaningful value,
> > >   to stop overloading the PCI bus (this also reduces the number of
> > >   resyncs by a factor of 3 or more in a long run; the actual number
> > >   is very dependent on a nature of the traffic).
> > >
> > >   Maintain the statistics counter as the hw.ste_rxsyncs sysctl.
> > 
> > This pollutes the toplevel hw sysctl space.  Please move it to
> > hw.ste.rxsyncs or better, debug.*.
> > 
> Seems I followed the bad practice from dc(4) and fxp(4).  I will
> move it to hw.ste, thanks.

Care to fix this "bad practice" in dc(4) and fxp(4) as well? :)  Or
should we wait for their maintainers, or possibly filling the PR ?

./danfe