cvs commit: ports/Mk bsd.gnome.mk

[David O'Brien]

On Thu, Sep 04, 2003 at 12:23:31PM -0400, Joe Marcus Clarke wrote:
> On Thu, 2003-09-04 at 04:31, David O'Brien wrote:
> > On Wed, Sep 03, 2003 at 08:48:04PM -0700, Joe Marcus Clarke wrote:
> > > marcus      2003/09/03 20:48:04 PDT
> > > 
> > >   FreeBSD ports repository
> > > 
> > >   Modified files:
> > >     Mk                   bsd.gnome.mk 
> > >   Log:
> > >   Back out the previous commit.  It was not approved, looks like was an
> > >   accidental commit based on the commit log, and was committed to the
> > >   deprecated macros section.
> > 
> > It was an accident, but it was also something you said could be committed
> > about a year ago.
> 
> Not me (I wasn't a committer years ago).

Only about a year ago -- someone on gnome at freebsd.org said that sobomax
wasn't the only GNOME guy and the patch was fine (back when he refused to
commit it).

> What problem is it trying to
> solve?  The X libraries are automatically depended on if you use gtk12
> or gtk20.  I looked at this a little last night, and I couldn't see a
> make package-depends output that was different with this option.  Do you
> have an example port?

ports/editors/vim -- I have to do this:

    .if defined(WITH_GNOME)
    USE_XLIB=   yes
    .endif

it may also be that the world has moved forward to the point that I can
remove this hack from vim/Makefile and I just didn't know it.

-- 
-- David  (obrien at FreeBSD.org)