cvs commit: ports/java/jdk13/files patch-iomgr.c

[Greg Lewis]

On Tue, May 06, 2003 at 10:34:36AM -0300, Mario Sergio Fujikawa Ferreira wrote:
> On Mon, May 05, 2003 at 11:10:40PM -0700, Greg Lewis wrote:
> > glewis      2003/05/05 23:11:02 PDT
> > 
> >   FreeBSD ports repository
> > 
> >   Added files:
> >     java/jdk13/files     patch-iomgr.c 
> >   Log:
> >   . Remove an assert() which asserts that if isatty() is true then
> >     ttyname() must not return NULL.  This isn't entirely true according
> >     to the manual page (the device must be able to be found as well) and
> >     certainly appears to not necessarily be true in the package building
> >     environment on bento (plus at least the PR submitter's environment).
> >   
> >     Note that this assert() was, of course, only ever triggered when
> >     running in debug mode (which most people don't, but does happen
> >     during the build in some parts).  Also note that there is a check
> >     for isatty() preceding the call for ttyname() and a NULL return
> >     from ttyname() is handled, so removing this assert should not
> >     create any problems.
> 
> 	Shouldn't we bump PORTREVISION?

Not for this commit (its only come up in very rare cases, and for those
cases they wouldn't have been able to build).  However, I should have
bumped it for the Math.pow() fix.  Thanks for the reminder :).

-- 
Greg Lewis                          Email   : glewis at eyesbeyond.com
Eyes Beyond                         Web     : http://www.eyesbeyond.com
Information Technology              FreeBSD : glewis at FreeBSD.org