cvs commit: src/bin/ls extern.h ls.c print.c util.c src/bin/pax ar_io.c ar_subs.c cache.c cpio.c extern.h gen_subs.c getoldopt.c options.c pat_rep.c pax.c pax.h src/bin/ps fmt.c src/bin/rcp rcp.c

[Giorgos Keramidas]

On 2003-05-03 23:55, Giorgos Keramidas <keramida at ceid.upatras.gr> wrote:
> On 2003-05-03 09:39, Mark Murray <markm at FreeBSD.org> wrote:
> >   Modified files:
> >     bin/ls               extern.h ls.c print.c util.c
> >     [...]
> >   Log:
> >   Fix a bazillion warnings. This makes almost the whole of src/bin/*
> >   WARNS=6, std=c99 clean.
>
> Now that you mentioned src/bin/...
> FWIW, my recent buildworlds break at bin/ps.
>
> [...]
> Index: bin/ps/Makefile
> ===================================================================
> RCS file: /home/ncvs/src/bin/ps/Makefile,v
> retrieving revision 1.23
> diff -u -r1.23 Makefile
> --- bin/ps/Makefile	2 May 2003 01:05:05 -0000	1.23
> +++ bin/ps/Makefile	3 May 2003 11:24:16 -0000
> @@ -9,7 +9,7 @@
>  # keep ps from being an unnecessary load
>  # on large systems.
>  #
> -WARNS=	1
> +WARNS=	0
>  WFORMAT=0
>  CFLAGS+=-DLAZY_PS
>  DPADD=	${LIBM} ${LIBKVM}

An alternative is to fix the warnings by using different strftime()
formats, but I'm not sure if this changes the output format of ps
output.  Could someone with more ps(1)-foo test this?  With this change
ps(1) builds with any WARNS level up to 5 here :-)

%%%
Index: Makefile
===================================================================
RCS file: /home/ncvs/src/bin/ps/Makefile,v
retrieving revision 1.23
diff -u -r1.23 Makefile
--- Makefile    2 May 2003 01:05:05 -0000       1.23
+++ Makefile    3 May 2003 21:04:19 -0000
@@ -9,7 +9,7 @@
 # keep ps from being an unnecessary load
 # on large systems.
 #
-WARNS= 1
+WARNS?= 5
 WFORMAT=0
 CFLAGS+=-DLAZY_PS
 DPADD= ${LIBM} ${LIBKVM}
Index: print.c
===================================================================
RCS file: /home/ncvs/src/bin/ps/print.c,v
retrieving revision 1.82
diff -u -r1.82 print.c
--- print.c	15 Apr 2003 18:49:20 -0000	1.82
+++ print.c	3 May 2003 20:59:25 -0000
@@ -402,7 +402,7 @@
 		(void)strftime(buf, sizeof(buf),
 		    use_ampm ? "%a%I%p" : "%a%H  ", tp);
 	} else
-		(void)strftime(buf, sizeof(buf), "%e%b%y", tp);
+		(void)strftime(buf, sizeof(buf), "%e%b%Y", tp);
 	(void)printf("%-*s", v->width, buf);
 }

@@ -419,7 +419,7 @@
 		return;
 	}
 	then = k->ki_p->ki_start.tv_sec;
-	(void)strftime(buf, sizeof(buf), "%c", localtime(&then));
+	(void)strftime(buf, sizeof(buf), "%a %b %e %T %Y", localtime(&then));
 	(void)printf("%-*s", v->width, buf);
 }

%%%