cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c

[Bruce Evans]

On Wed, 23 Jul 2003, Poul-Henning Kamp wrote:

> In message <20030722231656.GA9715 at HAL9000.homeunix.com>, David Schultz writes:
>
> Please remember that the problem at hand is getting -Werror back
> on the kernel so we can catch issues like the warning in umtx.

Straw problem.  Kernel developers can easily turn off -Winline and
turn on -Werror.  I turned off -Winline in my version of the old version
of -current that I use a few minutes after importing gcc, and never
turned off -Werror:

%%%
Index: kern.mk
===================================================================
RCS file: /home/ncvs/src/sys/conf/kern.mk,v
retrieving revision 1.31
diff -u -2 -r1.31 kern.mk
--- kern.mk	13 Oct 2002 02:52:22 -0000	1.31
+++ kern.mk	11 Jul 2003 14:45:37 -0000
@@ -8,5 +8,5 @@
 # also pop up, but are easier to fix.
 CWARNFLAGS?=	-Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes \
-		-Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual \
+		-Wmissing-prototypes -Wpointer-arith -Wcast-qual \
 		-fformat-extensions -ansi
 #
%%%

> We could either do that by lobotomizing the warning in the compiler
> or by setting the limit high enough to inline everything so marked.
>
> Since the warning has indeed pointed out a fair number of bogus
> inlines, the first option did not seem attractive.

Turning off -Winline essentially gives the gcc-3.2 brokenness of
-Winline without touching the compiler.

-Winline has been turned off for a long time for the i386 LINT, as a
side effect of the i386 LINT testing high resolution profiling and
-Winline actually producing warnings for the high resolution profiling
case (-finstrument-functions at least used to conflict with inliniing).
No one seemed to notice when I turned it off.

Bruce