cvs commit: src/sys/dev/wl if_wl.c
Alfred Perlstein
bright at mu.org
Wed Apr 16 11:35:10 PDT 2003
* John Baldwin <jhb at FreeBSD.org> [030416 11:06] wrote:
>
> On 16-Apr-2003 John Hay wrote:
> > jhay 2003/04/16 10:42:38 PDT
> >
> > FreeBSD src repository
> >
> > Modified files:
> > sys/dev/wl if_wl.c
> > Log:
> > Add locking and remove all the spl() calls.
>
> Note that some of the spl calls covered structures other than
> just the softc. I'd prefer that we leave spl calls in until
> all the structures they cover are locked.
John is right, leaving spls in is the right thing to do until we're
pretty much _done_ with smp locking the entire kernel. They serve
as a good marker where there may be cross domain locking issues.
--
-Alfred Perlstein [alfred at freebsd.org]
'Instead of asking why a piece of software is using "1970s technology,"
start asking why software is ignoring 30 years of accumulated wisdom.'
More information about the cvs-all
mailing list