[Bug 276465] sysutils/garcon: Missing dependency on Gnome icons

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=276465

--- Comment #3 from Guido Falsi <madpilot@FreeBSD.org> ---
(In reply to Olga Smirnova from comment #2)

I see what you mean, but I am wary of just adding a dependency to fix this
issue, which is anyway indirect.

I need to understand what are the missing icons. While the gnome icon theme
happens to contain them, there could be other themes including them, or maybe
they could be added to a theme already installed by xfce.

The gnome-icon-theme in the ports tree is also quite old, so maybe the icons
references in garcon need to be updated?

Even accepting to add a dependency I'm not sure adding it to garcon is the
correct place. I think it should be added to the xfce metaport.

garcon is an xfce component, while users are free, if they want to to mix and
match xfce components, the supported way to install xfce is to use the
metaport. If a user mixes and matches components it is his duty to make sure he
installs a consistent set.

XFCE at present depends directly (optionally, enabled by default) on
xfce-icons-elementary and causes a bunch of other icon libraries to be
installed via dependencies already. Before adding another dependency I'd rather
try to add the required icons to one of these themes. Or maybe changing the
reference to another icon present in the more updated themes already depended
upon. Upstream is usually very helpful in such matters.

You could help by pointing me at where in the source code these missing icons
are referenced. If you cannot help in such a way I will try to find time to do
this myself.

Please note, I'm not refusing your suggestion, I'm only saying that before
applying it blindly some further research is needed, because better solution
could be possible, and I need to thoroughly understand the issue to investigate
all those.

-- 
You are receiving this mail because:
You are the assignee for the bug.